Skip to content

glslang: Enable tests #479398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
OPNA2608 wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

glslang: Enable tests #479398

OPNA2608 wants to merge 1 commit into from

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jan 12, 2026 •
edited
Loading

KhronosGroup/glslang#4140

KhronosGroup/glslang#3799 says that this fails on non-LE platforms, but the problematic tool in question was moved to SPIRV-tools in KhronosGroup/glslang@3a7f787, so that might no longer be an issue…
Making a note to check this out the next time my ppc64 machine is free, and send a follow-up PR to disable them on !stdenv.hostPlatform.isLittleEndian if they still fail.

Fails on non-LE due to different issues, skipping affected part of the tests.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • powerpc64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Jan 12, 2026
@nixpkgs-ci nixpkgs-ci bot requested a review from Ralith January 12, 2026 16:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Jan 12, 2026
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Jan 13, 2026

Making a note to check this out the next time my ppc64 machine is free

Squeezed this in just now. gtest-based test suite has two failures on big-endian.

  1. UB in an error message, leading to different output:
    Glsl/CompileToAstTest.FromFile/array_frag fails on s390x because error-message depends on endianness KhronosGroup/glslang#2797
  2. Something that looks like an endian-related issue with some strings, and some things not parsing correctly:
    Glsl/GlslNonSemanticShaderDebugInfoSpirv13Test.FromFile/spv_debuginfo_coopmatKHR_comp fails on ppc64 KhronosGroup/glslang#4145

So will skip that part of the tests on BE.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ralith Ralith Ralith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OPNA2608 @Ralith