bitcoin: add missing cmake config flags #398911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the build system changes in Bitcoin Core v29.0, the dependecies are now opt-in. See https://bitcoincore.org/en/releases/29.0/#build-system To support the same features as in v28.1, ZMQ and the BDB legacy wallet are enabled here.
The Bitcoin Core upstream GUIX release builds enable WITH_USDT. To match these, enable this here too.
github-actions
bot
added
10.rebuild-darwin: 1-10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commits add the ZMQ and BDB cmake flags that were missed in #398586 as they were previously opt-out and are now opt-in. The second commit adds the tracepoint functionality to match the upstream GUIX release builds.
That ZMQ is available can be tested with
./result/bin/bitcoind --help | grep zmq, andreadelf -n result/bin/bitcoindcan be used to list the tracepoints.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.