-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
gcc14: fix internal compiler error on aarch64 #398407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I rebuilt #377785 on top of this branch and confirmed the GCC 14 patch fixed the torch 2.6.0 build issue on aarch64. |
|
NB: This is blocking the pytorch update. |
|
Perhaps we should bump the snapshot again, if these fixes are already upstream? |
They are upstream, but only in trunk (gcc 15) - they have not been backported to gcc 14 branch yet as can be seen in the upstream bugzilla. |
|
I don't object. I just don't have capacity to verify that backporting this makes sense (probably it's OK). |
|
Successfully built this on aarch64, and considering it's in gcc trunk like this and fixes aarch64 builds, I think it's fine to land this 👍 |
This PR combines fixes of these 3 upstream issues:
All 3 are related to segfault (internal compiler error) caused by the
force_subregfunction and are fixed by using the newforce_lowpart_subregfunctionHopefully all 3 fixes will become part of the 14.3.0 release but until then we should patch them locally since the ICE can be triggered by compiling torch 2.6.0 on aarch64 and thus this blocks torch update in #377785.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.