Skip to content

Update WasabiWallet v2.0.8.1 -> v2.5.1 #395909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prusnak merged 1 commit into from
Apr 11, 2025
Merged

Update WasabiWallet v2.0.8.1 -> v2.5.1 #395909

prusnak merged 1 commit into from
Apr 11, 2025

Conversation

@lontivero
Copy link
Contributor

@lontivero lontivero commented Apr 4, 2025 •
edited
Loading

Description of changes

I updated the version to the latest v2.5.1 and also included two new executables:

  • wasabiwallet-coordinator (Wasabi Wallet coinjoin coordinator) and
  • wasabiwallet-backend (Wasabi Wallet backend)

I also renamed the executables:

  • wassabeed renamed as wasabiwallet-daemon and
  • wassabee renamed as wasabiwallet-desktop

Release note: https://github.com/zkSNACKs/WalletWasabi/releases/tag/v2.5.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 24.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Maintainer pings

cc @mmahut for testing.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 4, 2025
@nix-owners nix-owners bot requested a review from mmahut April 4, 2025 02:34
Prince213
Prince213 requested changes Apr 6, 2025
View reviewed changes
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 7, 2025
Prince213
Prince213 requested changes Apr 7, 2025
View reviewed changes
Copy link
Member

@Prince213 Prince213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat commit messages so they conform to https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 7, 2025
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 7, 2025
@lontivero lontivero requested a review from Prince213 April 8, 2025 02:27
Prince213
Prince213 requested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@Prince213 Prince213 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit messages, please use lowercase for the package name (wasabiwallet), otherwise LGTM.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Apr 9, 2025
@lontivero lontivero requested a review from Prince213 April 10, 2025 18:41
@lontivero
Copy link
Contributor Author

lontivero commented Apr 11, 2025

Hey @prusnak, could you take a look at this PR, please?

prusnak
prusnak requested changes Apr 11, 2025
View reviewed changes
@prusnak
Copy link
Member

prusnak commented Apr 11, 2025 •
edited
Loading

please squash the second commit into the first one and we can merge, thanks!

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 11, 2025
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 11, 2025
@prusnak prusnak merged commit dbc11c4 into NixOS:master Apr 11, 2025
16 of 20 checks passed
@prusnak
Copy link
Member

prusnak commented Apr 11, 2025

amazing, thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prusnak prusnak prusnak approved these changes

@Prince213 Prince213 Prince213 approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lontivero @prusnak @Prince213