maintainers: add myself and GZGavinZhao to rocm team#391142
Merged
prusnak merged 2 commits intoNixOS:masterfrom Mar 19, 2025
Merged
maintainers: add myself and GZGavinZhao to rocm team#391142prusnak merged 2 commits intoNixOS:masterfrom
prusnak merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
8.has: maintainer-list (update)
mschwaig
suggested changes
Mar 19, 2025
Member
mschwaig
left a comment
mschwaig
left a comment
There was a problem hiding this comment.
please also remove Madouura, thank you @Madouura for your work on ROCm in the past.
At the same time, are lucky to have you and @GZGavinZhao involved now!
wegank
added
the
12.approvals: 1
LunNova
force-pushed
the
rocm-maintainers-update
branch
from
9cbcb26 to
62be204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer list update for rocm team. Closes #385288
These two commits were part of #367695, splitting to avoid maintainer-list conflicts.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.