Skip to content

haskellPackages.miso-examples: build with js backend#380737

Merged
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
alexfmpe:misoverse
Mar 18, 2025
Merged

haskellPackages.miso-examples: build with js backend#380737
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
alexfmpe:misoverse

Conversation

@alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Feb 9, 2025

$ nix-build -A pkgsCross.ghcjs.haskell.packages.ghc912.miso-action-logger
/nix/store/q085a26dp38kzjy0q2pyghgzfblnv1rc-miso-action-logger-0.1.0.1
$ nix-build -A pkgsCross.ghcjs.haskell.packages.ghc912.miso-examples
/nix/store/2r9dqw1phig9m8ldk1rvfk21wi6a05nf-miso-examples-1.8.7.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 9, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 9, 2025
@alexfmpe alexfmpe force-pushed the misoverse branch 2 times, most recently from ba0529d to 0c0c5cc Compare February 9, 2025 22:27
@sternenseemann
Copy link
Member

sternenseemann commented Feb 10, 2025

I suppose we bump hackage a little again? dmjio/miso#740 (comment)

@sternenseemann
Copy link
Member

#380707 has miso-examples-1.8.6.0. Stackage LTS still restricts miso to 1.8.5.0, but it could be manually upgraded.

@dmjio
Copy link
Member

dmjio commented Feb 10, 2025

I'm going to push 1.8.7 now, per a CPP fix made today in order for miso-examples to compile without that patch (in this PR).

@alexfmpe alexfmpe marked this pull request as draft February 11, 2025 02:14
@alexfmpe
Copy link
Member Author

alexfmpe commented Feb 11, 2025

Confirmed this builds with the 1.8.7 versions.
Given miso-examples doesn't actually run yet with pkgsCross.ghcjs (some linking stuff ?) and it's not a library, I'm drafting until we next bump hackage.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@alexfmpe alexfmpe marked this pull request as ready for review February 19, 2025 13:32
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 19, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 19, 2025
Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe a hydra job for this would be cool. But not in this PR.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 9, 2025
@maralorn maralorn merged commit 8875f67 into NixOS:haskell-updates Mar 18, 2025
29 checks passed
@alexfmpe alexfmpe deleted the misoverse branch June 14, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants