haskellPackages.miso-examples: build with js backend#380737
Merged
maralorn merged 3 commits intoNixOS:haskell-updatesfrom Mar 18, 2025
Merged
haskellPackages.miso-examples: build with js backend#380737maralorn merged 3 commits intoNixOS:haskell-updatesfrom
maralorn merged 3 commits intoNixOS:haskell-updatesfrom
Conversation
ba0529d to
0c0c5cc
Compare
Member
|
I suppose we bump hackage a little again? dmjio/miso#740 (comment) |
Member
|
#380707 has miso-examples-1.8.6.0. Stackage LTS still restricts miso to 1.8.5.0, but it could be manually upgraded. |
Member
|
I'm going to push 1.8.7 now, per a CPP fix made today in order for miso-examples to compile without that patch (in this PR). |
Member
Author
|
Confirmed this builds with the 1.8.7 versions. |
Merged
13 tasks
maralorn
approved these changes
Mar 9, 2025
Member
maralorn
left a comment
There was a problem hiding this comment.
LGTM
Maybe a hydra job for this would be cool. But not in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.