Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexusmods-app: 0.7.1 -> 0.7.2 #375824

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Conversation

MattSturgeon
Copy link
Contributor

@MattSturgeon MattSturgeon commented Jan 22, 2025

Also:

  • Still need .NET 8 runtime available while building, for the StrawberryShake dependency 😦
  • Replaced usage of convert with magick to resolve deprecation warnings in the build log.
  • The package's tests still seem flaky, they failed when building locally
    • Actually building/running the app works fine though

Notes for end-users

Tip

When upgrading from version 0.7.0 or newer, it should be safe to upgrade without resetting/uninstalling.

Caution

When upgrading from a version older than 0.7.0, you will need a fresh start.
If you have configuration leftover from an old version, the updated app will crash.

See upstream's guide on how to uninstall the app.

Resetting tips

You can reset all modded games and wipe your nexusmods-app config using:

NexusMods.App uninstall-app
  • This should be done before updating the app.
  • Be careful: There's no way to recover a wiped config!

If you've run the appimage version from upstream, or a pre-0.6 nixpkgs version, you may also need to remove old desktop entries to avoid other issues:

rm ~/.local/share/applications/com.nexusmods.app.desktop

Caution

Known issues are listed on the changelog, but include:

  • Stardew Valley (Native Linux version) is not detected when installed via Heroic Launcher on Linux. The Windows version of the game can be used instead until this issue is fixed.
  • Bundled mods included with collections do not appear in the UI but are still applied to your game.
  • The success rating for collections is not showing the correct value.
  • The game version is not checked when adding a collection meaning you can install outdated mods without being warned.
  • The Collections (WIP) page is not filtered by game.
  • The "Switch View" option does not persist in the Library/Installed Mods view.
  • The "Load Order" heading toggle does not persist in the Load Order view.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Resolves the following warning during the install phase:

WARNING: The convert command is deprecated in IMv7, use "magick" instead of "convert" or "magick convert"
@MattSturgeon MattSturgeon added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 22, 2025
@corngood
Copy link
Contributor

Out of curiosity, did the update script work? I take it you didn't get an automatic update PR from the bot?

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 22, 2025
@MattSturgeon
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375824


x86_64-linux

✅ 2 packages built:
  • nexusmods-app
  • nexusmods-app-unfree

@MattSturgeon
Copy link
Contributor Author

Out of curiosity, did the update script work?

I ran ./pkgs/by-name/ne/nexusmods-app/update.bash, out of habbit...

Testing again on master:

$ nix-shell maintainers/scripts/update.nix --argstr package nexusmods-app

Going to be running update for following packages:
 - nexusmods-app-0.7.1

Press Enter key to continue...

Running update for:
 - nexusmods-app-0.7.1: UPDATING ...
 - nexusmods-app-0.7.1: DONE.

Packages updated!

I noticed that unlike running update.bash manually, the update script sits on UPDATING ... for ages without printing any output from the underlying script. A little frustrating to not see any feedback.

But after waiting several minutes, it did complete successfully.

I take it you didn't get an automatic update PR from the bot?

I haven't seen one (not sure what it'd look like, unless you mean one like #329592). This release only came out yesterday though, so maybe the bot hasn't had chance to check for updates yet?

@corngood
Copy link
Contributor

unless you mean one like #329592

Yeah, like that. Someone pointed me at where the logs live: https://r.ryantm.com/log/nexusmods-app/, and it looks like it's only run every couple weeks or so?

Thanks for checking.

@SuperSandro2000
Copy link
Member

I don't understand why ofborg is failing to build the package

@MattSturgeon
Copy link
Contributor Author

MattSturgeon commented Jan 22, 2025

I don't understand why ofborg is failing to build the package

Interesting:

  Failed NexusMods.Games.StardewValley.Tests.StardewValleyInstallersTests.CanInstallMod(filename: "Portraits_for_Vendors.zip") [813 ms]
  Error Message:
   VerifyException : Directory: /build/NexusMods.App/tests/Games/NexusMods.Games.StardewValley.Tests
NotEqual:
  - Received: StardewValleyInstallersTests.CanInstallMod_filename=Portraits_for_Vendors.zip.received.txt
    Verified: StardewValleyInstallersTests.CanInstallMod_filename=Portraits_for_Vendors.zip.verified.txt

I also don't have this error locally...

Maybe we should add "NexusMods.Games.StardewValley.Tests.StardewValleyInstallersTests.CanInstallMod" to disabledTests?

Scrolling through the log, there's a few errors like Failed to start a process with file path 'xdg-settings' (also for xdg-open), but I think these are unrelated.

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Jan 23, 2025
Passes locally, but fails on ofborg.
@MattSturgeon
Copy link
Contributor Author

MattSturgeon commented Jan 25, 2025

I've disabled the test. Ofborg seems happy now 🎉

@wegank wegank removed the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Jan 25, 2025
@SuperSandro2000 SuperSandro2000 merged commit 9bc6468 into NixOS:master Jan 25, 2025
4 of 6 checks passed
@MattSturgeon MattSturgeon deleted the nexus-0.7.2 branch January 25, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants