python3Packages.taichi: init at 1.7.3 #370780
Open
+248
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
|
lucasew
reviewed
Jan 4, 2025
lucasew
reviewed
Jan 4, 2025
lucasew
reviewed
Jan 4, 2025
| enableVulkan ? stdenv.isLinux, | ||
| }: | ||
|
|
||
| let |
There was a problem hiding this comment.
This is the only point I am not sure how to do.
Most attributes are needed both in the taichi cmake build phase (compiling the c-api) and the taichi python packaging in buildPythonPackage. If I used rec, I would have to maintain everything twice 🤔
lucasew
reviewed
Jan 4, 2025
lucasew
reviewed
Jan 4, 2025
lucasew
reviewed
Jan 4, 2025
|
|
1 similar comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #367617, but instead of building from PyPI, this one builds from source!
[llvm_context.cpp:operator()@80] LLVM Fatal Error: Undefined external symbol "__stack_chk_fail".rocmPackagesare not updated to6.3.x, I won't be testing it.TODO:
.gitdirectory is still present.Solution: faking a
.gitfolder.Submodules found under
external:DirectX-HeadersNot needed, now windows supportamdgpu_libdevice,cuda_libdevice, andincludeare local folders.Some of the submodules are frozen to certain commits, so if we would move to building using the version from nixpkgs instead of those, one needs to check first if everything still works!
Con: does it still compile/work with newer versions? 📉
Pro: easier dependency maintenance 📈 👀
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.