synchrony: init at 2.4.5 #352833
Open
synchrony: init at 2.4.5 #352833
+140
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| passthru = { | ||
| tests.deobfuscate = | ||
| let | ||
| obfuscated = fetchurl { |
There was a problem hiding this comment.
Why not fetch both obfuscated and deobfuscated?
There was a problem hiding this comment.
There's no deobfuscated version provided by upstream — I had to run this on my local machine
There was a problem hiding this comment.
I suppose that doesn't stop you from uploading the deobfuscated file to gist.github.com though.
There was a problem hiding this comment.
I suppose that doesn't stop you from uploading the deobfuscated file to gist.github.com though.
True, though that feels like more work than just sourcing from a file in-tree
pluiedev
force-pushed
the
init/synchrony
branch
from
134a86f
to
366f8b0
Compare
pluiedev
force-pushed
the
init/synchrony
branch
from
366f8b0
to
e50f859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352355
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.