Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortwave: 3.2.0 -> 4.0.1, move to by-name #352786

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zendo
Copy link
Contributor

@zendo zendo commented Nov 1, 2024

Changelog:
https://gitlab.gnome.org/World/Shortwave/-/blob/main/data/de.haeckerfelix.Shortwave.metainfo.xml.in.in?ref_type=heads#L78

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

(shortwave:117290): Gtk-WARNING **: 12:58:25.730: Could not load image '___object_18___ 
                    ': Error opening file /home/aleksana/.cache/nixpkgs-review/pr-352786/___object_18___ 
                    : No such file or directory
 ERROR mdns_sd::service_daemon > Failed to send SearchStarted(_googlecast._tcp.local.)(repeating:true): sending on a closed channel
screenshots

image
image

@Aleksanaa
Copy link
Member

Will take a look later

@zendo
Copy link
Contributor Author

zendo commented Nov 1, 2024

It refused to connect when VPN enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants