Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprsome: init at 0.1.12 #352677

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

hyprsome: init at 0.1.12 #352677

wants to merge 2 commits into from

Conversation

BhasherBEL
Copy link
Contributor

Adds hyprsome, a tool for interacting with hyprland workspaces. Up to date version of #259495 which is now stale for long.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@zi3m5f zi3m5f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their own README.md says:

Alternatives

https://github.com/Duckonaut/split-monitor-workspaces leverages the plugin system, is more feature rich and seems better maintained

And split-monitor-workspaces:

hyprsome: An earlier project of similar nature

Sure you don't want to add the other one? ;)

How can I check version 0.1.12 is rev = "985e1a3b03b5118c98c03983f60ea9f74775858c";?

You missed https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

When adding yourself as maintainer in the same pull request, make a separate commit with the message maintainers: add . Add the commit before those making changes to the package or module. See Nixpkgs Maintainers for details.

pkgs/by-name/hy/hyprsome/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hy/hyprsome/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hy/hyprsome/package.nix Outdated Show resolved Hide resolved
@BhasherBEL
Copy link
Contributor Author

BhasherBEL commented Nov 1, 2024

Sure you don't want to add the other one? ;)

They indeed cite another tool, and it may be interesting to add it (but I don't personally use it) but their is still active and used :)

How can I check version 0.1.12 is rev = "985e1a3b03b5118c98c03983f60ea9f74775858c";?

Sadly they don't have special branches, tags, ... for versions. It just happens that the last version is 0.1.12.

The other points you raised should be fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants