Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python312Packages.cfn-lint (3 failing pytests) #352092

Closed
wants to merge 1 commit into from

Conversation

GnRlLeclerc
Copy link

@GnRlLeclerc GnRlLeclerc commented Oct 29, 2024

The python312Packages.cfn-lint package is currently broken because of 3 failing pytests. Some tests are already ignored in the nixpkgs definition for this package, so I suppose we may as well ignore these 3 other tests.

This currently breaks python312Packages.tensorboardx which uses it as a dependency.

Reproducing:

  1. Checkout the master branch of nixpkgs
  2. Run nix build .#python312Packages.cfn-lint

No maintainer.

Things done

Added 3 tests to the ignore list.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4769

@GnRlLeclerc
Copy link
Author

Temporary overlay for those who need it now:

(final: prev: {
  python312 = prev.python312.override {
    packageOverrides = final: prevPy: {

      # Temporary fix for python312Packages.cfn-lint (ignore some other tests that fail)
      cfn-lint = prevPy.cfn-lint.overridePythonAttrs (oldAttrs: {
        disabledTests = oldAttrs.disabledTests ++ [
          "test_quickstart_templates"
          "test_quickstart_templates_non_strict"
          "test_quickstart_templates_non_strict"
        ];
      });
    };
  };
  python312Packages = final.python312.pkgs;
})

@fabaff
Copy link
Member

fabaff commented Oct 29, 2024

An update to a later release (1.18.1) is in staging-nextnow.

@GnRlLeclerc
Copy link
Author

An update to a later release (1.18.1) is in staging-nextnow.

Should I close this PR, then? I'll check for upcoming updates before submitting fixes next time.

@fabaff
Copy link
Member

fabaff commented Oct 29, 2024

Tests are passing in staging-next.

@fabaff
Copy link
Member

fabaff commented Nov 1, 2024

@GnRlLeclerc GnRlLeclerc closed this Nov 1, 2024
@GnRlLeclerc GnRlLeclerc deleted the fix-cfn-lint branch November 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants