Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envision-unwrapped: 0-unstable-2024-09-28 -> 0-unstable-2024-10-20; envision: update dependency list and extraInstallCommands #349917

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

Pandapip1
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 changed the title envision: Two minor changes envision: Three minor changes Oct 20, 2024
@ofborg ofborg bot requested a review from Scrumplex October 20, 2024 05:03
@Pandapip1 Pandapip1 changed the title envision: Three minor changes envision-unwrapped: 0-unstable-2024-09-28 -> 0-unstable-2024-10-20; envision: update dependency list and extraInstallCommands Oct 20, 2024
@Pandapip1 Pandapip1 marked this pull request as draft October 20, 2024 07:03
@Pandapip1
Copy link
Contributor Author

Moving to draft while I re-test the changes.

@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Oct 20, 2024

WiVRn build succeeded and the result runs. Testing WMR next.

EDIT: WMR build succeeded and the result runs. Testing Lighthouse next.

EDIT: Lighthouse build succeeded and the result runs; Tried OpenHMD but its build seems to currently fail. Not a blocker as OpenHMD is deprecated IIUC. Testing Survive next.

EDIT: Survive runs. Marking PR as ready for review.

@Pandapip1 Pandapip1 marked this pull request as ready for review October 20, 2024 07:57
@Scrumplex Scrumplex merged commit 3deb4e1 into NixOS:master Nov 1, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants