Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.term-image: init at 0.7.2 #347924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liff
Copy link
Contributor

@liff liff commented Oct 11, 2024

Add term-image, needed (optionally) by a new release of toot.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff
Copy link
Member

fabaff commented Oct 12, 2024

Result of nixpkgs-review pr 347924 run on x86_64-linux 1

4 packages built:
  • python311Packages.term-image
  • python311Packages.term-image.dist
  • python312Packages.term-image
  • python312Packages.term-image.dist

@liff
Copy link
Contributor Author

liff commented Oct 12, 2024

Thanks for the review, @fabaff, I’ve applied your suggestions.

@liff liff mentioned this pull request Nov 1, 2024
13 tasks
@liff
Copy link
Contributor Author

liff commented Nov 1, 2024

@Aleksanaa applied your suggestions, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants