deepsource: init at 0.8.6 #324286
Open
deepsource: init at 0.8.6 #324286
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
FliegendeWurst
suggested changes
Oct 24, 2024
Aleksanaa
reviewed
Nov 1, 2024
| "-w" | ||
| "-X=main.version=${version}" | ||
| ]; | ||
|
|
There was a problem hiding this comment.
This program supports generating completion.
postInstall = lib.optionals (stdenv.build.canExecute stdenv.hostPlatform) ''
installShellCompletion --cmd deepsource \
--bash <($out/bin/deepsource completion bash) \
--fish <($out/bin/deepsource completion fish) \
--zsh <($out/bin/deepsource completion zsh)
'';
There was a problem hiding this comment.
Also would be good to add a https://nixos.org/manual/nixpkgs/unstable/#versioncheckhook if possible.
| hash = "sha256-6uNb4cQVerrlW/eUkjmlO1i1YKYX3qaVdo0i5cczt+I="; | ||
| }; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Indicate why in a comment on top of or behind this line.
Comment on lines
28
to
44
| meta = with lib; { | ||
| description = "Command line interface to DeepSource"; | ||
| mainProgram = "deepsource"; | ||
| homepage = "https://github.com/DeepSourceCorp/cli"; | ||
| license = licenses.bsd2; | ||
| maintainers = with maintainers; [ nipeharefa ]; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| description = "Command line interface to DeepSource"; | |
| mainProgram = "deepsource"; | |
| homepage = "https://github.com/DeepSourceCorp/cli"; | |
| license = licenses.bsd2; | |
| maintainers = with maintainers; [ nipeharefa ]; | |
| }; | |
| meta = { | |
| description = "Command line interface to DeepSource"; | |
| mainProgram = "deepsource"; | |
| homepage = "https://github.com/DeepSourceCorp/cli"; | |
| license = lib.licenses.bsd2; | |
| maintainers = with lib.maintainers; [ nipeharefa ]; | |
| }; |
| ]; | ||
|
|
||
| meta = with lib; { | ||
| description = "Command line interface to DeepSource"; |
There was a problem hiding this comment.
Suggested change
| description = "Command line interface to DeepSource"; | |
| description = "Command line interface to DeepSource, the code health platform"; |
Aleksanaa
reviewed
Nov 1, 2024
nipeharefa
force-pushed
the
deepsource
branch
from
fd16190
to
5dfff5a
Compare
|
done @Aleksanaa |
nipeharefa
force-pushed
the
deepsource
branch
2 times, most recently
from
4542add
to
d52cf3f
Compare
nipeharefa
force-pushed
the
deepsource
branch
from
d52cf3f
to
62e7398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.