Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.SDL: fix on perl >= 5.38.0 #256402

Merged
merged 2 commits into from
Sep 21, 2023
Merged

perlPackages.SDL: fix on perl >= 5.38.0 #256402

merged 2 commits into from
Sep 21, 2023

Conversation

puckipedia
Copy link
Contributor

Description of changes

Fixes #255381

Uses patch not otherwise applied upstream yet.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@puckipedia
perlPackages.SDL: fix on perl >= 5.38.0
73afddd 
This applies the patch from [1], fixing the most important game in
nixpkgs.

[1]: PerlGameDev/SDL#304
stigtsp
stigtsp requested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

The patch looks good to me, and builds/test.

However: Since the commit it's not yet merged into https://github.com/PerlGameDev/SDL can you add it as a .patch file in nixpkgs?

@stigtsp
Copy link
Member

stigtsp commented Sep 21, 2023

@ofborg build perlPackages.SDL frozen-bubble

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 21, 2023
@stigtsp stigtsp merged commit c9a6670 into NixOS:master Sep 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@zakame zakame Awaiting requested review from zakame

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: frozen-bubble
3 participants
@puckipedia @stigtsp @delroth