bfg-repo-cleaner: init -> 1.12.15

[leenaars]

Motivation for this change

BFG Repo-Cleaner is a useful tool for changing git history and a dependency for cregit (https://github.com/cregit/cregit), a tool to determine authorship inside git repositories I'm packaging.

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[copumpkin]

Looks like @changlinli already added this: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/version-management/git-and-tools/bfg-repo-cleaner/default.nix

[Mic92]

an top-level alias might help.

[leenaars]

I'm building my version from source, and need this because I need to patch it for use with cregit - which uses a patch which has been a pull request since 2015:

rtyley/bfg-repo-cleaner#83

(a dependency for https://github.com/cregit/cregit)

So what should I do? Add as a private dependency for cregit, or replace the version in pkgs?

[copumpkin]

Unless you go through some weird hoops that we haven't standardized yet, your source sbt build is going to be impure (it'll reach out to resolve ivy dependencies and even the scala compiler/stdlib itself), and thus will not work on Hydra or many Nix configurations.

[copumpkin]

I don't have a good solution; you could make a separate expression or put the work into purifying the sbt build, but for now I'd just leave your version in the same file as cregit's expression with a comment explaining what's up. I also posted a comment upstream on BFG asking them to merge the PR

[leenaars]

Will do so.

[copumpkin]

@leenaars cool, thanks! Note that cregit will still not build on Hydra until the purity issue is resolved. To test what would happen on Hydra, run nix-build with --option build-use-sandbox true, which will disable all network connectivity from the builder.

[changlinli]

@Mic92 Fair enough. #25420