Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task-keeper: init at 0.12.2 #236516

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

task-keeper: init at 0.12.2 #236516

wants to merge 6 commits into from

Conversation

tennox
Copy link
Contributor

@tennox tennox commented Jun 7, 2023

Description of changes

New package: task-keeper

tk(Task Keeper) is a tool to manage tasks from different task files, such as Makefile,justfile, package.json , deno.jso, .fleet/run.json etc, and call tasks from different project management tools, such as Apache Maven, Gradle, Cargo and npm etc.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Manu [tennox] added 2 commits June 7, 2023 20:38
I realized that this pattern is well-known and works :)
better than using a fork
Manu [tennox] added 3 commits November 24, 2023 15:59
Also:
- moved back to my fork
  (until the PR is merged: linux-china/task-keeper#5)
- removed the Cargo.lock, which is now part of the repo
- set `meta.mainProgram` correctly
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
};

cargoLock = {
lockFile = "${src}/Cargo.lock";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the lockfile has to be copied to nixpkgs, unfortunately

Copy link
Contributor Author

@tennox tennox Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Isn't it deterministic because it is referenced by git commit and hash?
I am using my fork as the source repo which has the lockfile... 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because lockFile can't be evaluated without downloading the source. This sort of trickery isn't allowed in nixpkgs. See https://github.com/NixOS/nixpkgs/tree/master/pkgs#import-from-derivation

pkgs/tools/misc/task-keeper/default.nix Outdated Show resolved Hide resolved
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants