Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sandboxing of pull_request_target workflow #280

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

AaronDewes
Copy link
Contributor

This restricts the action to be no longer able to push content, so it can only comment on PRs or open and close (not merge) them.

This means that even if someone manages to bypass the sandboxing somehow, they can not really exploit this workflow to extract secrets etc.

This restricts the action to be no longer able to push content, so it can only comment on PRs or open and close (not merge) them.

This means that even if someone manages to bypass the sandboxing somehow, they can not really exploit this workflow to extract secrets etc.
Copy link

github-actions bot commented Jan 26, 2025

Nixpkgs diff

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@infinisil infinisil merged commit e825e95 into NixOS:master Jan 27, 2025
2 checks passed
@AaronDewes AaronDewes deleted the patch-1 branch January 27, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants