Refactor client-react-hooks and the examples-nextjs to use the grpc client #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix esbuild Pnpm workspaces facilitates proper tsc resolution because it makes workspace peers available in node_modules. If the exact same value is also in `tsconfig.json` then esbuild considers the dependency part of the package and includes it in the build causing downstream issues.
… web with a single bundle
Provided consuming environments support top level await, this is the simplest approach to supporting node and web standards with a single bundle. This expects the default `wasm-pack` target is used (eg `wasm-pack --target bundle`) and then one must manually edit index.js to arrive at:
```ts
import { __wbg_set_wasm } from "./index_bg.js";
const wasm = await import('./index_bg.wasm');
__wbg_set_wasm(wasm);
export * from "./index_bg.js";
```
When there were 5+ packages it made sense to consolidate the esbuild logic but this is no longer the case and so this helps reduce complexity.
…ntiation Given that permissions will always be default or set explicitly, this instantiates the builder with the default set to avoid situations where permissions hasn't been explicitly set.
…Status>` This is so `queryPoolStatus` follows the same structure as the other methods on VmClient.
Replaced by `examples-nextjs`.
Although `#/...` was concise it broke typechecking in the hooks project and I'm unsure how to fix it. So, reverting to the approach were we use the package name directly.
tim-hm
force-pushed
the
timhm/feat-react-hooks-to-grpc-client
branch
from
008591e
to
5f10c71
Compare
Also, add `src/index.js` which replaces the wasm-pack generated index.js.
Because `dist/index.mjs` hasn't been built when tests run, suites should not relay on top level imports `@nillion/client-vms` and should prefer nested imports `@nillion/client-vms/types` because vite will correctly resolve the latter in the test context.
tim-hm
force-pushed
the
timhm/feat-react-hooks-to-grpc-client
branch
from
3735528
to
58f327e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.