This repository has been archived by the owner on Jul 8, 2020. It is now read-only.
Update to work with jsdom v10+ #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdom v10 introduced a new api, incompatible with previous versions. This caused "TypeError: require(...).jsdom is not a function" when jest-environment-jsdom-debug was used with jsdom v10 or later. As new versions of jsdom still support the old api for now, fix by requiring the "old api", which is available on the new versions, and fall back to the previous code otherwise. Note use of var to get around block scoping of const with try/catch. I'm not a javascript developer, I just need to do some quick and dirty work on a js project and I want a debugger. My code probably sucks, please, please feel free to change to something more appropriate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsdom v10 introduced a new api, incompatible with previous versions.
This caused "TypeError: require(...).jsdom is not a function" when
jest-environment-jsdom-debug was used with jsdom v10 or later.
As new versions of jsdom still support the old api for now, fix by
requiring the "old api", which is available on the new versions, and
fall back to the previous code otherwise.
Note use of var to get around block scoping of const with try/catch.
I'm not a javascript developer, I just need to do some quick and dirty
work on a js project and I want a debugger. My code probably sucks,
please, please feel free to change to something more appropriate.