Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add overwrite functionality to the BoxFileWriterClass #103

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

ToneVDB
Copy link
Contributor

@ToneVDB ToneVDB commented Nov 14, 2024

Description

Add an overwrite flag to the BoxFileWriter class

Related Issue

Parially solves #89

Motivation and Context

When writing to box and the file already exists, you want to be able to overwrite the existing file with a new version

How Has This Been Tested?

This has been tested on databricks and box - when a file exists and doesn't, the writer does the right thing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ToneVDB ToneVDB requested a review from a team as a code owner November 14, 2024 08:23
@dannymeijer dannymeijer changed the base branch from main to release/0.9 November 14, 2024 09:52
@dannymeijer dannymeijer merged commit 79f32aa into Nike-Inc:release/0.9 Nov 21, 2024
12 checks passed
@dannymeijer dannymeijer linked an issue Nov 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add box functionality
3 participants