Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

150 - Support for yaml extension in project conf files #175

Merged

Conversation

riccamini
Copy link
Contributor

Description

Support for yaml (and potentially others) extension in project config files

Related Issue

#150

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asingamaneni
Copy link
Collaborator

Is this PR ready for review?

@riccamini
Copy link
Contributor Author

Not yet, I still need to add tests to cover the changes

@riccamini riccamini marked this pull request as ready for review November 15, 2024 16:48
@riccamini riccamini changed the title WIP - 150 - Support for yaml extension in project conf files 150 - Support for yaml extension in project conf files Nov 15, 2024
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asingamaneni asingamaneni merged commit 5230b09 into Nike-Inc:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants