-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (protocol): pre testnet release updates #53
base: main
Are you sure you want to change the base?
Conversation
blockMaxProposals: 324_000, | ||
blockRingBufferSize: 360_000, | ||
maxBlocksToVerify: 16, | ||
blockMaxGasLimit: 240_000_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Limit should be 600MGas given a 3 second block time
maxBlocksToVerify: 16, | ||
blockMaxGasLimit: 240_000_000, | ||
livenessBond: 0.07 ether, | ||
stateRootSyncInternal: 16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didnt we say this should be 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the testnet/mainnet too? Thought we were doing that for the devnet for our convenience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the expected low number of blocks proposed, im leaning towards yes. Let me know if the consequences of changing it would be grave. What kind of extra cost do we expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going to 25K-50K extra gas per proof since this change on its own is not very relevant. We add this with the "verify on every proof" change that I spoke about two days ago. So, the entire verification flow is also executed. If we are confident that 16 blocks won't take a huge time to show up, we should keep the Taiko specified constants imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set different values for mainnet testnet. I think for testnet, we can keep the 16, but for mainnet we should set it low as my expectation in the beginning to have very few blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking bout it, since testnet eth is abundant, we can keep it low for both mainnet and testnet
baseFeeConfig: LibSharedData.BaseFeeConfig({ | ||
adjustmentQuotient: 8, | ||
sharingPctg: 75, | ||
gasIssuancePerSecond: 5_000_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is gas issuance?
surge
folders under both contracts and scripts.Surge: <change description>