-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p restructure #2342
p2p restructure #2342
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2342 +/- ##
==========================================
+ Coverage 74.59% 74.61% +0.01%
==========================================
Files 110 110
Lines 11908 11908
==========================================
+ Hits 8883 8885 +2
+ Misses 2338 2336 -2
Partials 687 687 ☔ View full report in Codecov by Sentry. |
Perhaps we should rename |
1a4651f
to
f596acf
Compare
|
22f28ce
to
f354107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much renaming 🫠. Could you make sure the PR works correctly with the latest version of main before merging?
f354107
to
e9ec3a8
Compare
e9ec3a8
to
3b693ed
Compare
Structure change:
Renamed
peers.go
tocodec.go
Protobuf generation
Changed from
protoc
tobuf
Added
generate-buf
to Makefile