Typos fix #2329
Typos fix #2329
Conversation
Signed-off-by: Romashka <[email protected]>
Signed-off-by: Romashka <[email protected]>
Signed-off-by: Romashka <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
==========================================
- Coverage 74.40% 74.37% -0.03%
==========================================
Files 109 109
Lines 11493 11493
==========================================
- Hits 8551 8548 -3
- Misses 2277 2279 +2
- Partials 665 666 +1 ☔ View full report in Codecov by Sentry. |
i check it. do you merge it ? |
CODE_OF_CONDUCT.md
Outdated
| @@ -69,7 +69,7 @@ Read carefully our Contributing Guidelines to know how to contribute properly in | |||
| project. Members and maintainers must adhere to some rules regarding to pull requests | |||
| reviews and creation of issues and pull requests: | |||
|
|
|||
| * During code reviews do not comment on coding standards and styles -focus on algorithmical, | |||
| * During code reviews do not comment on coding standards and styles -focus on algorithmically, | |||
There was a problem hiding this comment.
I think correct version should be:
During code reviews do not comment on coding standards and styles -focus on algorithmic,
structural or naming issues-, help to solve problem.
There was a problem hiding this comment.
I think correct version should be:
During code reviews do not comment on coding standards and styles -focus on algorithmic, structural or naming issues-, help to solve problem.
yes, you are correct , but i think you can merge my version.
There was a problem hiding this comment.
@romashka-btc please update this line with algorithmic instead of algorithmically
|
@AnkushinDaniil @kirugan what why you do not merge it ? i delete old also. |
Could you please make those changes @kirugan asked you to? Unfortunately we can't merge until you've finished. Thanks so much! |
Signed-off-by: Romashka <[email protected]>
Signed-off-by: Romashka <[email protected]>
if i need do something more, write me. |
There was a problem hiding this comment.
There seems to be a mistake here, you have removed a whole CODE_OF_CONDUCT.md
There was a problem hiding this comment.
There seems to be a mistake here, you have removed a whole
CODE_OF_CONDUCT.md
hmmm, and what you reccomend to do now ? @AnkushinDaniil
There was a problem hiding this comment.
This commit appears to be correct 368fb7c
Try reverting to this commit
There was a problem hiding this comment.
This commit appears to be correct 368fb7c Try reverting to this commit
ok, i will do it in 5-8 hours, pls do not close it, because i need go to work now. @AnkushinDaniil thank you !
There was a problem hiding this comment.
This commit appears to be correct 368fb7c Try reverting to this commit
i can not reverting it.
There was a problem hiding this comment.
This commit appears to be correct 368fb7c Try reverting to this commit
maybe you will add only another changes ?
There was a problem hiding this comment.
I'm so sorry, but I can't. Why not have a go at finding out how to do that yourself? I'm sure you'd be able to manage it, it's not that difficult.
There was a problem hiding this comment.
I'm so sorry, but I can't. Why not have a go at finding out how to do that yourself? I'm sure you'd be able to manage it, it's not that difficult.
i do not understaand what i need to do. can you help me?
Fix: Corrected typos in documentation and code comments
What was changed
algorithmicaltoalgorithmicallyinCODE_OF_CONDUCT.md(line 72).decendingtodescendingincore\state.go(line 399).panicingtopanickingindb\db.go(line 111).Why these changes were made
Additional Notes