upgrade dependencies to prepare jdk17 upgrade #563
Conversation
| @@ -25,4 +25,8 @@ | |||
| <Bug code="RCN" /> | |||
| </Match> | |||
|
|
|||
| <Match> | |||
| <Bug pattern="CT_CONSTRUCTOR_THROW"/> | |||
There was a problem hiding this comment.
Good, excluding this is the right way to go
| implementation("com.google.inject.extensions:guice-persist") | ||
| implementation("com.google.inject.extensions:guice-multibindings") | ||
| implementation("com.google.inject.extensions:guice-servlet") | ||
| implementation("joda-time:joda-time:2.10.10") |
There was a problem hiding this comment.
Curious why this needed to have version pinned to this
There was a problem hiding this comment.
If I don't add the version, I will get the following error.
Failed to resolve 'joda-time:joda-time' for project 'metacat-connector-s3'
The following dependencies are missing a version: joda-time:joda-time
|
When we try to run functional test under jdk 17, we get the below exception: Doing some search online: Thus we are not able to upgrade metacat to jdk17 due to hms incompatibility with java version older than 8. |
insyncoss
deleted the
yingjianw/upgrade_depedencies_to_prepark_jdk17_upgrade
branch
Background:
We are not able to upgrade to jdk17 right now since hms is too old and is not compatible with jdk17. We will deprecate hms soon, and once it is deprecated, metacat can be upgraded to jdk17.
For this PR, we update metacat dependencies besides hms to be compatible with jdk17.
Testing plan: