Skip to content

Commit

Permalink
set cluster info type to Catalog Type (#569)
Browse files Browse the repository at this point in the history
* set cluster info type to Catalog Type

* adjust test

---------

Co-authored-by: Yingjian Wu <[email protected]>
  • Loading branch information
stevie9868 and Yingjian Wu authored Feb 8, 2024
1 parent a4cd4a5 commit 216fac7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public static MetacatCatalogConfig createFromMapAndRemoveProperties(
final String clusterEnv = properties.get(Keys.CLUSTER_ENV);
final String clusterRegion = properties.get(Keys.CLUSTER_REGION);
final ClusterInfo clusterInfo =
new ClusterInfo(clusterName, type, clusterAccount, clusterAccountId, clusterEnv, clusterRegion);
new ClusterInfo(clusterName, catalogType, clusterAccount, clusterAccountId, clusterEnv, clusterRegion);

return new MetacatCatalogConfig(catalogType, catalogName, clusterInfo, includeViewsWithTables, schemaWhitelist,
schemaBlacklist, thriftPort, cacheEnabled, interceptorEnabled, hasDataExternal);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ class TableServiceImplSpec extends Specification {
def usermetadataService = Mock(UserMetadataService)
def eventBus = Mock(MetacatEventBus)
def converterUtil = Mock(ConverterUtil)
def catalogConfig = MetacatCatalogConfig.createFromMapAndRemoveProperties('hive', 'a', ['metacat.interceptor.enabled': 'true', 'metacat.has-data-external':'true'])
def catalogConfigFalse = MetacatCatalogConfig.createFromMapAndRemoveProperties('hive', 'a', ['metacat.interceptor.enabled': 'false', 'metacat.has-data-external':'false'])
def catalogConfig = MetacatCatalogConfig.createFromMapAndRemoveProperties('migration', 'a', ['metacat.interceptor.enabled': 'true', 'metacat.has-data-external':'true', 'metacat.type': 'hive'])
def catalogConfigFalse = MetacatCatalogConfig.createFromMapAndRemoveProperties('migration', 'a', ['metacat.interceptor.enabled': 'false', 'metacat.has-data-external':'false', 'metacat.type': 'hive'])
def registry = new NoopRegistry()
def config = Mock(Config)
def tableDto = DataDtoProvider.getTable('a', 'b', 'c', "amajumdar", "s3:/a/b")
Expand Down

0 comments on commit 216fac7

Please sign in to comment.