don't reset description when pushing new workflow (#66)

Co-authored-by: jun-he <[email protected]>
Netflix · Aug 1, 2024 · e6b73ef · e6b73ef
1 parent ba72c05
commit e6b73ef
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/maestro-engine/src/main/java/com/netflix/maestro/engine/db/PropertiesUpdate.java b/maestro-engine/src/main/java/com/netflix/maestro/engine/db/PropertiesUpdate.java
@@ -170,9 +170,6 @@ public Properties getNewProperties(
  Properties currentProperties = prevSnapshot.extractProperties();
 
  // If certain properties are undefined in newly pushed wf definition, reset them
- if (newProperties.getDescription() == null) {
- currentProperties.setDescription(null);
- }
  if (newProperties.getRunStrategy() == null) {
  currentProperties.setRunStrategy(null);
  }

diff --git a/maestro-engine/src/test/java/com/netflix/maestro/engine/dao/MaestroWorkflowDaoTest.java b/maestro-engine/src/test/java/com/netflix/maestro/engine/dao/MaestroWorkflowDaoTest.java
@@ -1280,12 +1280,10 @@ public void testGetNewProperties() throws Exception {
  assertNotNull(resetNotAllowed.getStepConcurrency());
  assertNotNull(resetNotAllowed.getOwner());
 
- // alerting, description, run strategy, step concurrency will get reset when it's
- // add_workflow path
+ // alerting, run strategy, step concurrency will get reset when it's add_workflow path
  Properties resetAllowed =
  new PropertiesUpdate(Type.ADD_WORKFLOW_DEFINITION).getNewProperties(newProps, ps);
  assertNull(resetAllowed.getAlerting());
- assertNull(resetAllowed.getDescription());
  assertNull(resetAllowed.getRunStrategy());
  assertNull(resetAllowed.getStepConcurrency());