Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Marshal() including "default=" tags in EnvSet #27

Merged
merged 4 commits into from
Oct 28, 2024
Merged

fix: Marshal() including "default=" tags in EnvSet #27

merged 4 commits into from
Oct 28, 2024

Conversation

kaandesu
Copy link
Contributor

Hello, I experienced the same issue in #23 and in this PR attempted to fix it.

@patricksanders patricksanders linked an issue Oct 25, 2024 that may be closed by this pull request
Marshal() includes "default=" tags in EnvSet output #23
Closed
patricksanders
patricksanders requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@patricksanders patricksanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks good, just needs a few more test cases.

env.go Show resolved Hide resolved
env.go Show resolved Hide resolved
@patricksanders patricksanders merged commit 6b7f898 into Netflix:master Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricksanders patricksanders patricksanders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marshal() includes "default=" tags in EnvSet output
2 participants
@kaandesu @patricksanders