Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force updating the job status to KILLED when killing a job that has a… #1192

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

bhou2
Copy link
Contributor

@bhou2 bhou2 commented Oct 20, 2023

Force updating the job status to KILLED when killing a job that has a connected agent but no response observer. It might be that the agent has gone but its status has not been updated. This PR aims to update the job status to KILLED and we will dig into more depth on the root cause of the inconsistency of the agent status.

@bhou2 bhou2 marked this pull request as draft October 20, 2023 21:43
@bhou2 bhou2 marked this pull request as ready for review October 20, 2023 21:46
@bhou2 bhou2 marked this pull request as draft October 20, 2023 21:46
@bhou2 bhou2 assigned bhou2 and unassigned bhou2 Oct 20, 2023
@bhou2 bhou2 marked this pull request as ready for review October 20, 2023 21:55
@bhou2 bhou2 requested a review from natadzen October 20, 2023 21:58
@bhou2 bhou2 marked this pull request as draft October 20, 2023 21:58
@bhou2 bhou2 marked this pull request as ready for review October 20, 2023 21:59
@bhou2 bhou2 requested review from akashdw and jun-he October 20, 2023 21:59
@bhou2 bhou2 marked this pull request as draft October 20, 2023 23:29
@bhou2 bhou2 force-pushed the force-kill branch 4 times, most recently from 24dbfbc to 7d40529 Compare October 23, 2023 19:01
@Netflix Netflix deleted a comment from codecov bot Oct 23, 2023
@Netflix Netflix deleted a comment from codecov bot Oct 24, 2023
@Netflix Netflix deleted a comment from codecov bot Oct 24, 2023
@Netflix Netflix deleted a comment from codecov bot Oct 24, 2023
@bhou2 bhou2 closed this Oct 24, 2023
@bhou2 bhou2 reopened this Oct 24, 2023
@Netflix Netflix deleted a comment from codecov bot Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1192 (c1a64f7) into master (c6c81dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1192   +/-   ##
=========================================
  Coverage     90.80%   90.80%           
  Complexity     3810     3810           
=========================================
  Files           467      467           
  Lines         14968    14976    +8     
  Branches       1071     1071           
=========================================
+ Hits          13591    13599    +8     
  Misses          901      901           
  Partials        476      476           
Files Coverage Δ
.../apis/rpc/v4/endpoints/GRpcJobKillServiceImpl.java 94.52% <100.00%> (+0.67%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bhou2 bhou2 marked this pull request as ready for review October 24, 2023 04:01
@bhou2 bhou2 merged commit 73aa7cc into master Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants