Use IPAddresses from HostSupplier rather than from AbstractTokenMapSu… #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplier We always used the IPs from the HostSupplier rather than the AbstractTokenMapSupplier as an undocumented subtlety. In the previous patch, this was changed as it seemed like a harmless change. Netflix@7b25392 Howver, the implication is that the client operates on Public IPs (which the AbstractTokenMapSupplier supplies), as opposed to the Private IPs (which the HostSupplier supplies), and in production, the Public IP range are generally not accessible by clients. Why does the AbstractTokenMapSupplier return public IPs? This is because the AbstractTokenMapSupplier derives its values from dynomite-manager which returns the topology seen by it and the server processes, and they use Public IPs to communicate with each other. TODO: Can we ensure that both the HostSupplier and AbstractTokenMapSupplier agree on the same values?
|
thanks for fixing this @smukil ! |
|
@rsrinivasanNetflix @smukil Could this have possibly fixed: #273 and #264 ? Would be good to know to close out some issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pplier
We always used the IPs from the HostSupplier rather than the
AbstractTokenMapSupplier as an undocumented subtlety.
In the previous patch, this was changed as it seemed like a harmless
change.
7b25392
Howver, the implication is that the client operates on Public IPs (which
the AbstractTokenMapSupplier supplies), as opposed to the Private IPs
(which the HostSupplier supplies), and in production, the Public IP
range are generally not accessible by clients.
Why does the AbstractTokenMapSupplier return public IPs?
This is because the AbstractTokenMapSupplier derives its values from
dynomite-manager which returns the topology seen by it and the server
processes, and they use Public IPs to communicate with each other.
TODO: Can we ensure that both the HostSupplier and AbstractTokenMapSupplier
agree on the same values?