This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisLainez
commented
Oct 26, 2023
api 'com.google.protobuf:protobuf-java:3.21.7' | ||
api 'javax.annotation:javax.annotation-api:1.3.2' | ||
api 'com.google.protobuf:protobuf-java:3.21.12' | ||
api 'jakarta.annotation:jakarta.annotation-api:2.1.1' | ||
api gradleApi() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add jakarta annotation. We move from javax -> jakarta
LuisLainez
commented
Oct 26, 2023
@@ -1,7 +1,7 @@ | |||
{ | |||
"annotationProcessor": { | |||
"org.springframework.boot:spring-boot-configuration-processor": { | |||
"locked": "2.7.3" | |||
"locked": "3.1.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade Spring to 3.1.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLock
to refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApply
to fix any format violations.Changes in this PR
Upgrading Conductor to Spring 3 - WARNING - Server doesn't start successfully.
The main changes are:
Describe the new behavior from this PR, and why it's needed
Issue #
Spring 2 is reaching its end of life and will no longer be maintained.
Alternatives considered
Describe alternative implementation you have considered