This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fix JSONPath replace failed with line terminator #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this does indeed seems to cover our cases, can we release this as a hotfix/patch? @v1r3n |
dpozinen
approved these changes
Oct 13, 2023
Young-Zen
added a commit
to Young-Zen/netflix-conductor
that referenced
this pull request
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #3804
This is because by default, the regular expression . matches any character except the line terminator: https://github.com/openjdk/jdk/blob/2edf9c3f1e968779c6e92b3e25d780db68ace5cc/src/java.base/share/classes/java/util/regex/Pattern.java#L890
Alternatives considered
Describe alternative implementation you have considered