This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
issue-3719: Fix for http task stuck due to NPE #3756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLock
to refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApply
to fix any format violations.Changes in this PR
Implemented the incorrect or empty methods implementation in the
DummyPayloadStorage
class, such asgetLocation()
,upload()
, anddownload()
. These methods now utilize Disk based approach to store and retrieve data. Prior to this implementation, these methods were either empty or returning null, which led to NullPointerExceptions and caused HTTP workers to become stuckAlternatives considered
Describe alternative implementation you have considered
We can create another Storage class and change the default value of
conductor.external-payload-storage.type
property pointing to that class, right now value ofconductor.external-payload-storage.type
isdummy
and this-code is conditionally creatingDummyPayloadStorage
bean