do not stringify null results in json jq task (#3225)

Netflix · Sep 8, 2022 · a2a64e6 · a2a64e6
1 parent 6413a12
commit a2a64e6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/json-jq-task/src/main/java/com/netflix/conductor/tasks/json/JsonJqTransform.java b/json-jq-task/src/main/java/com/netflix/conductor/tasks/json/JsonJqTransform.java
@@ -124,7 +124,9 @@ private String extractFirstValidMessage(final Exception e) {
     }
 
     private Object extractBody(JsonNode node) {
-        if (node.isObject()) {
+        if (node.isNull()) {
+            return null;
+        } else if (node.isObject()) {
             return objectMapper.convertValue(node, mapType);
         } else if (node.isArray()) {
             return objectMapper.convertValue(node, listType);

diff --git a/json-jq-task/src/test/java/com/netflix/conductor/tasks/json/JsonJqTransformTest.java b/json-jq-task/src/test/java/com/netflix/conductor/tasks/json/JsonJqTransformTest.java
@@ -148,6 +148,7 @@ public void stringResultShouldBeCorrectlyExtracted() {
         assertEquals("CREATE", result);
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void listResultShouldBeCorrectlyExtracted() throws JsonProcessingException {
         final JsonJqTransform jsonJqTransform = new JsonJqTransform(objectMapper);
@@ -170,4 +171,19 @@ public void listResultShouldBeCorrectlyExtracted() throws JsonProcessingExceptio
         List<Object> result = (List<Object>) task.getOutputData().get("result");
         assertEquals(3, result.size());
     }
+
+    @Test
+    public void nullResultShouldBeCorrectlyExtracted() throws JsonProcessingException {
+        final JsonJqTransform jsonJqTransform = new JsonJqTransform(objectMapper);
+        final WorkflowModel workflow = new WorkflowModel();
+        final TaskModel task = new TaskModel();
+        final Map<String, Object> taskInput = new HashMap<>();
+        taskInput.put("queryExpression", "null");
+        task.setInputData(taskInput);
+
+        jsonJqTransform.start(workflow, task, null);
+
+        assertNull(task.getOutputData().get("error"));
+        assertNull(task.getOutputData().get("result"));
+    }
 }