Merge pull request #3644 from astelmashenko/bugfix/message-queue-dead…

…-tasks removing dead tasks from queue message
Netflix · Jun 8, 2023 · 878fcd9 · 878fcd9
2 parents e11a3e7 + a709ad2
commit 878fcd9
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/core/src/main/java/com/netflix/conductor/core/execution/AsyncSystemTaskExecutor.java b/core/src/main/java/com/netflix/conductor/core/execution/AsyncSystemTaskExecutor.java
@@ -64,6 +64,18 @@ public void execute(WorkflowSystemTask systemTask, String taskId) {
         TaskModel task = loadTaskQuietly(taskId);
         if (task == null) {
             LOGGER.error("TaskId: {} could not be found while executing {}", taskId, systemTask);
+            try {
+                LOGGER.debug(
+                        "Cleaning up dead task from queue message: taskQueue={}, taskId={}",
+                        systemTask.getTaskType(),
+                        taskId);
+                queueDAO.remove(systemTask.getTaskType(), taskId);
+            } catch (Exception e) {
+                LOGGER.error(
+                        "Failed to remove dead task from queue message: taskQueue={}, taskId={}",
+                        systemTask.getTaskType(),
+                        taskId);
+            }
             return;
         }