identifierString() -> toShortString()

Netflix · Mar 25, 2021 · 1d54e1e · 1d54e1e
1 parent 5084409
commit 1d54e1e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/common/src/main/java/com/netflix/conductor/common/run/Workflow.java b/common/src/main/java/com/netflix/conductor/common/run/Workflow.java
@@ -550,7 +550,7 @@ public String toString() {
      * A string representation of all relevant fields that identify this workflow.
      * Intended for use in log and other system generated messages.
      */
-    public String identifierString() {
+    public String toShortString() {
         return String.format("%s.%s/%s", getWorkflowName(), getWorkflowVersion(), workflowId);
     }
 

diff --git a/core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java b/core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutor.java
@@ -588,7 +588,7 @@ private void updateAndPushParents(Workflow workflow) {
             executionDAOFacade.updateTask(subWorkflowTask);
 
             // add an execution log
-            String currentWorkflowIdentifier = workflow.identifierString();
+            String currentWorkflowIdentifier = workflow.toShortString();
             workflowIdentifier = !workflowIdentifier.equals("") ? String.format("%s -> %s", currentWorkflowIdentifier, workflowIdentifier) : currentWorkflowIdentifier;
             TaskExecLog log = new TaskExecLog(String.format("Workflow %s changed.", workflowIdentifier));
             log.setTaskId(subWorkflowTask.getTaskId());
@@ -774,7 +774,7 @@ Workflow completeWorkflow(Workflow workflow) {
 
         if (workflow.hasParent()) {
             updateParentWorkflowTask(workflow);
-            LOGGER.info("{} updated parent {} task {}", workflow.identifierString(), workflow.getParentWorkflowId(), workflow.getParentWorkflowTaskId());
+            LOGGER.info("{} updated parent {} task {}", workflow.toShortString(), workflow.getParentWorkflowId(), workflow.getParentWorkflowTaskId());
             queueDAO.pushIfNotExists(DECIDER_QUEUE, workflow.getParentWorkflowId(), properties.getSweepFrequency().getSeconds());
         }
 
@@ -828,7 +828,7 @@ public Workflow terminateWorkflow(Workflow workflow, String reason, String failu
 
             if (workflow.hasParent()) {
                 updateParentWorkflowTask(workflow);
-                LOGGER.info("{} updated parent {} task {}", workflow.identifierString(), workflow.getParentWorkflowId(), workflow.getParentWorkflowTaskId());
+                LOGGER.info("{} updated parent {} task {}", workflow.toShortString(), workflow.getParentWorkflowId(), workflow.getParentWorkflowTaskId());
                 queueDAO.pushIfNotExists(DECIDER_QUEUE, workflow.getParentWorkflowId(), properties.getSweepFrequency().getSeconds());
             }
 

diff --git a/core/src/main/java/com/netflix/conductor/core/execution/tasks/SubWorkflow.java b/core/src/main/java/com/netflix/conductor/core/execution/tasks/SubWorkflow.java
@@ -188,7 +188,7 @@ private void updateTaskStatus(Workflow subworkflow, Task task) {
                 task.getOutputData().putAll(subworkflow.getOutput());
             }
             if(!status.isSuccessful()) {
-                task.setReasonForIncompletion(String.format("Sub workflow %s failure reason: %s", subworkflow.identifierString(), subworkflow.getReasonForIncompletion()));
+                task.setReasonForIncompletion(String.format("Sub workflow %s failure reason: %s", subworkflow.toShortString(), subworkflow.getReasonForIncompletion()));
             }
         }
     }