lwc-events: support enums as tag values (#1652)

Add support for mapping Java Enum types to tag string values.
Netflix · Apr 10, 2024 · c75e8fb · c75e8fb
1 parent b8af6f3
commit c75e8fb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/atlas-lwc-events/src/main/scala/com/netflix/atlas/lwc/events/LwcEvent.scala b/atlas-lwc-events/src/main/scala/com/netflix/atlas/lwc/events/LwcEvent.scala
@@ -43,8 +43,9 @@ trait LwcEvent {
     */
   def tagValue(key: String): String = {
     extractValue(key) match {
-      case v: String => v
-      case _         => null
+      case v: String  => v
+      case e: Enum[_] => e.name()
+      case _          => null
     }
   }
 

diff --git a/atlas-lwc-events/src/test/scala/com/netflix/atlas/lwc/events/LwcEventSuite.scala b/atlas-lwc-events/src/test/scala/com/netflix/atlas/lwc/events/LwcEventSuite.scala
@@ -18,6 +18,8 @@ package com.netflix.atlas.lwc.events
 import com.netflix.atlas.core.util.SortedTagMap
 import munit.FunSuite
 
+import java.lang.System.Logger
+
 class LwcEventSuite extends FunSuite {
 
   import LwcEventSuite.*
@@ -33,6 +35,10 @@ class LwcEventSuite extends FunSuite {
     assertEquals(sampleLwcEvent.tagValue("node"), "i-123")
   }
 
+  test("tagValue: enum") {
+    assertEquals(sampleLwcEvent.tagValue("level"), "TRACE")
+  }
+
   test("tagValue: missing") {
     assertEquals(sampleLwcEvent.tagValue("foo"), null)
   }
@@ -80,6 +86,7 @@ object LwcEventSuite {
     key match {
       case "tags"     => span.tags
       case "duration" => span.duration
+      case "level"    => Logger.Level.TRACE
       case k          => span.tags.getOrElse(k, null)
     }
   }