Merge pull request #82 from Netflix/feature/fix_nonstatic_loggers

Fixing non static loggers to be static, and marking non final loggers to be final

evcache-client/src/main/java/com/netflix/evcache/pool/DIEVCacheKetamaNodeLocatorConfiguration.java

@@ -13,7 +13,7 @@
 
 public class DIEVCacheKetamaNodeLocatorConfiguration extends EVCacheKetamaNodeLocatorConfiguration {
 
-    private static Logger log = LoggerFactory.getLogger(DIEVCacheKetamaNodeLocatorConfiguration.class);
+    private static final Logger log = LoggerFactory.getLogger(DIEVCacheKetamaNodeLocatorConfiguration.class);
     private final EurekaClient eurekaClient;
 
     public DIEVCacheKetamaNodeLocatorConfiguration(EVCacheClient client, EurekaClient eurekaClient) {

evcache-client/src/main/java/com/netflix/evcache/pool/eureka/DIEVCacheNodeListProvider.java

@@ -14,7 +14,7 @@
 
 public class DIEVCacheNodeListProvider implements Provider<EVCacheNodeList> {
 
-    private static Logger log = LoggerFactory.getLogger(DIEVCacheNodeListProvider.class);
+    private static final Logger log = LoggerFactory.getLogger(DIEVCacheNodeListProvider.class);
     private final EurekaClient eurekaClient;
     private PropertyRepository props;
     private final ApplicationInfoManager applicationInfoManager;

evcache-client/src/main/java/com/netflix/evcache/pool/eureka/EurekaNodeListProvider.java

@@ -35,7 +35,7 @@ public class EurekaNodeListProvider implements EVCacheNodeList {
     public static final String DEFAULT_PORT = "11211";
     public static final String DEFAULT_SECURE_PORT = "11443";
 
-    private static Logger log = LoggerFactory.getLogger(EurekaNodeListProvider.class);
+    private static final Logger log = LoggerFactory.getLogger(EurekaNodeListProvider.class);
     private final EurekaClient _eurekaClient;
     private PropertyRepository props;
     private final ApplicationInfoManager applicationInfoManager;

evcache-client/src/main/java/com/netflix/evcache/version/VersionTracker.java

@@ -19,7 +19,7 @@
 @Singleton
 public class VersionTracker implements Runnable {
 
-	private static Logger log = LoggerFactory.getLogger(VersionTracker.class);
+	private static final Logger log = LoggerFactory.getLogger(VersionTracker.class);
     private AtomicLong versionGauge;
     private EVCacheClientPoolManager poolManager;
 

evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java

@@ -63,7 +63,7 @@
     "DB_DUPLICATE_BRANCHES", "REC_CATCH_EXCEPTION","RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" })
 final public class EVCacheImpl implements EVCache {
 
-    private static Logger log = LoggerFactory.getLogger(EVCacheImpl.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheImpl.class);
 
     private final String _appName;
     private final String _cacheName;

evcache-core/src/main/java/com/netflix/evcache/operation/EVCacheBulkGetFuture.java

@@ -47,7 +47,7 @@
 @SuppressWarnings("restriction")
 public class EVCacheBulkGetFuture<T> extends BulkGetFuture<T> {
 
-    private Logger log = LoggerFactory.getLogger(EVCacheBulkGetFuture.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheBulkGetFuture.class);
     private final Map<String, Future<T>> rvMap;
     private final Collection<Operation> ops;
     private final CountDownLatch latch;

evcache-core/src/main/java/com/netflix/evcache/operation/EVCacheFuture.java

@@ -13,7 +13,7 @@
 
 public class EVCacheFuture implements Future<Boolean> {
 
-    private Logger log = LoggerFactory.getLogger(EVCacheFuture.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheFuture.class);
     private final Future<Boolean> future;
     private final String app;
     private final ServerGroup serverGroup;

evcache-core/src/main/java/com/netflix/evcache/operation/EVCacheFutures.java

@@ -20,7 +20,7 @@
 public class EVCacheFutures implements ListenableFuture<Boolean, OperationCompletionListener>,
         OperationCompletionListener {
 
-    private Logger log = LoggerFactory.getLogger(EVCacheFutures.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheFutures.class);
     private final OperationFuture<Boolean>[] futures;
     private final String app;
     private final ServerGroup serverGroup;

evcache-core/src/main/java/com/netflix/evcache/operation/EVCacheOperationFuture.java

@@ -54,7 +54,7 @@
 @edu.umd.cs.findbugs.annotations.SuppressFBWarnings("EXS_EXCEPTION_SOFTENING_HAS_CHECKED")
 public class EVCacheOperationFuture<T> extends OperationFuture<T> {
 
-    private Logger log = LoggerFactory.getLogger(EVCacheOperationFuture.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheOperationFuture.class);
 
     private final CountDownLatch latch;
     private final AtomicReference<T> objRef;

evcache-core/src/main/java/com/netflix/evcache/pool/EVCacheClient.java

@@ -69,7 +69,7 @@
         "RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE" })
 public class EVCacheClient {
 
-    private static Logger log = LoggerFactory.getLogger(EVCacheClient.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheClient.class);
     private final ConnectionFactory connectionFactory;
     private final EVCacheMemcachedClient evcacheMemcachedClient;
     private final List<InetSocketAddress> memcachedNodesInZone;

evcache-core/src/main/java/com/netflix/evcache/pool/EVCacheClientPool.java

@@ -50,7 +50,7 @@
 @edu.umd.cs.findbugs.annotations.SuppressFBWarnings({ "PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS", "REC_CATCH_EXCEPTION", "MDM_THREAD_YIELD" })
 public class EVCacheClientPool implements Runnable, EVCacheClientPoolMBean {
 
-    private static Logger log = LoggerFactory.getLogger(EVCacheClientPool.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheClientPool.class);
 
     private final String _appName;
     private final String _zone;

evcache-core/src/main/java/com/netflix/evcache/pool/EVCacheClientUtil.java

@@ -15,7 +15,7 @@
 import net.spy.memcached.CachedData;
 
 public class EVCacheClientUtil {
-    private static Logger log = LoggerFactory.getLogger(EVCacheClientUtil.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheClientUtil.class);
     private final ChunkTranscoder ct = new ChunkTranscoder();
     private final String _appName;
     private final EVCacheClientPool _pool;

evcache-core/src/main/java/com/netflix/evcache/pool/EVCacheNodeLocator.java

@@ -23,7 +23,7 @@
 
 public class EVCacheNodeLocator implements NodeLocator {
 
-    private static Logger log = LoggerFactory.getLogger(EVCacheNodeLocator.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheNodeLocator.class);
     private TreeMap<Long, MemcachedNode> ketamaNodes;
     protected final EVCacheClient client;
 

evcache-core/src/main/java/com/netflix/evcache/pool/SimpleNodeListProvider.java

@@ -29,7 +29,7 @@
 
 public class SimpleNodeListProvider implements EVCacheNodeList {
 
-    private static Logger log = LoggerFactory.getLogger(EVCacheClientPool.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheClientPool.class);
     private static final String EUREKA_TIMEOUT = "evcache.eureka.timeout";
 
     private String currentNodeList = "";

evcache-core/src/main/java/com/netflix/evcache/util/KeyHasher.java

@@ -27,7 +27,7 @@ public class KeyHasher {
 
 
 
-    private static Logger log = LoggerFactory.getLogger(KeyHasher.class);
+    private static final Logger log = LoggerFactory.getLogger(KeyHasher.class);
     private static final Encoder encoder= Base64.getEncoder().withoutPadding();
 
 //    public static String getHashedKey1(String key, String hashingAlgorithm) {

evcache-core/src/main/java/net/spy/memcached/EVCacheConnection.java

@@ -16,7 +16,7 @@
 import net.spy.memcached.ops.Operation;
 
 public class EVCacheConnection extends MemcachedConnection {
-    private static Logger log = LoggerFactory.getLogger(EVCacheConnection.class);
+    private static final Logger log = LoggerFactory.getLogger(EVCacheConnection.class);
 
     public EVCacheConnection(String name, int bufSize, ConnectionFactory f,
             List<InetSocketAddress> a, Collection<ConnectionObserver> obs,

evcacheproxy/src/main/java/com/netflix/evcache/service/resources/EVCacheRESTService.java

@@ -30,7 +30,7 @@
 @Path("/evcrest/v1.0")
 public class EVCacheRESTService {
 
-    private Logger logger = LoggerFactory.getLogger(EVCacheRESTService.class);
+    private static final Logger logger = LoggerFactory.getLogger(EVCacheRESTService.class);
 
     private final EVCache.Builder builder;
     private final Map<String, EVCache> evCacheMap;