Fixed issue with transcoding multiple times

Netflix · Sep 9, 2020 · 6e542b3 · 6e542b3
1 parent 369cb94
commit 6e542b3
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java b/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java
@@ -1917,20 +1917,24 @@ protected <T> EVCacheLatch set(String key, T value, Transcoder<T> tc, int timeTo
             for (EVCacheClient client : clients) {
                 String canonicalKey = evcKey.getCanonicalKey(client.isDuetClient());
                 String hashKey = evcKey.getHashKey(client.isDuetClient(), client.getHashingAlgorithm(), client.shouldEncodeHashKey(), client.getMaxHashingBytes());
-                if (tc != null) {
-                    cd = tc.encode(value);
-                } else if (_transcoder != null) {
-                    cd = ((Transcoder<Object>) _transcoder).encode(value);
-                } else {
-                    cd = client.getTranscoder().encode(value);
+                if(cd == null) {
+                    if (tc != null) {
+                        cd = tc.encode(value);
+                    } else if (_transcoder != null) {
+                        cd = ((Transcoder<Object>) _transcoder).encode(value);
+                    } else {
+                        cd = client.getTranscoder().encode(value);
+                    }
                 }
                 if (hashKey != null) {
                     final EVCacheValue val = new EVCacheValue(canonicalKey, cd.getData(), cd.getFlags(), timeToLive, System.currentTimeMillis());
-                    cd = evcacheValueTranscoder.encode(val);
+                    final CachedData cdHashed = evcacheValueTranscoder.encode(val);
+                    final Future<Boolean> future = client.set(hashKey, cdHashed, timeToLive, latch);
+                    if (log.isDebugEnabled() && shouldLog()) log.debug("SET : APP " + _appName + ", Future " + future + " for hashed key : " + evcKey);
+                } else {
+                    final Future<Boolean> future = client.set(canonicalKey, cd, timeToLive, latch);
+                    if (log.isDebugEnabled() && shouldLog()) log.debug("SET : APP " + _appName + ", Future " + future + " for key : " + evcKey);
                 }
-                final Future<Boolean> future = client.set(hashKey == null ? canonicalKey : hashKey, cd, timeToLive, latch);
-                if (log.isDebugEnabled() && shouldLog())
-                    log.debug("SET : APP " + _appName + ", Future " + future + " for key : " + evcKey);
             }
             if (event != null) {
                 event.setTTL(timeToLive);