Fix: Increase padding for tensor alignment in offloading #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I increased the padding for offloaded tensors earlier, to fix this issue, #887, I have missed the following line: https://github.com/Nerogar/OneTrainer/blob/5f6ed6a63effbc5afe10cf1162b869c0858279d2/modules/util/LayerOffloadConductor.py#L251 Apparently it didn't cause any issues, but it could be less efficient because the cache for activation offloading gets allocated too small? Requires testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I increased the padding for offloaded tensors earlier, to fix this issue, #887, I have missed the following line:
OneTrainer/modules/util/LayerOffloadConductor.py
Line 251 in 5f6ed6a
Should probably be 16 also. Apparently this didn't cause any issues so far, but it could be less efficient because the cache for activation offloading gets allocated too small?
Requires testing