-
-
Notifications
You must be signed in to change notification settings - Fork 258
Advanced Optimizers 2.0: torch.compile support, enhancements, etc. #1224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
self.layer_state[layer_key]['sum_sq_accumulator'] += torch.sum(grad.detach().pow(2)).float() in Kourkoutas.py gives error when used with cpu offloading in Onetrainer (device mismatch) also compiled optimizer setting required to run OT venv using the native cmd for visual studio otherwise fatal error C1083: Cannot open include file: 'omp.h' error |
This is odd.
I don't understand this issue; it works for me (and it should work, as it's just a standard optimizer setting for OT). |
Should be fixed in dev2, can you confirm? |
|
This is now well-tested and ready. The only remaining issue is Muon's strange interaction with |
|
renamed |
Rework of #1083
It’s pretty stable and ready (just needs testing).
More info: Koratahiu/Advanced_Optimizers#12