-
-
Notifications
You must be signed in to change notification settings - Fork 258
Upgrade to torch 2.9.1 #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dxqb
wants to merge
7
commits into
Nerogar:master
Choose a base branch
from
dxqb:torch_2_9_1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−19
Open
Upgrade to torch 2.9.1 #1189
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
68113b8
upgrade to torch 2.9.1
dxqb 5d1d4ac
Merge branch 'upstream' into torch_2_9_1
dxqb 1ab0c46
workaround for https://github.com/pytorch/pytorch/issues/170398
dxqb 98ca133
Merge branch 'upstream' into torch_2_9_1
dxqb 9af0046
merge
dxqb 28e5d1b
Bump triton-windows ver. Uses shorter internal paths.
O-J1 2997d83
Bump B&B ver to 0.49.1 as discussed
O-J1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| # pytorch | ||
| --extra-index-url https://download.pytorch.org/whl/cu128 | ||
| torch==2.8.0+cu128 | ||
| torchvision==0.23.0+cu128 | ||
| onnxruntime-gpu==1.22.0 | ||
| nvidia-nccl-cu12==2.27.3; sys_platform == "linux" | ||
| triton-windows==3.4.0.post20; sys_platform == "win32" | ||
| torch==2.9.1+cu128 | ||
| torchvision==0.24.1+cu128 | ||
| onnxruntime-gpu==1.23.2 | ||
| nvidia-nccl-cu12==2.27.5; sys_platform == "linux" | ||
| triton-windows==3.5.1.post24; sys_platform == "win32" | ||
|
|
||
| # optimizers | ||
| bitsandbytes==0.46.0 # bitsandbytes for 8-bit optimizers and weight quantization | ||
| bitsandbytes==0.49.1 # bitsandbytes for 8-bit optimizers and weight quantization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # pytorch | ||
| torch==2.8.0 | ||
| torchvision==0.23.0 | ||
| onnxruntime==1.22.1 | ||
| torch==2.9.1 | ||
| torchvision==0.24.1 | ||
| onnxruntime==1.23.2 | ||
|
|
||
| # optimizers | ||
| # TODO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add
bitsandbyteshere but not inrequirements-global.txtorrequirements-cpu.txtbecause macOS doesn't support 8-bit optimizers and that's like 90% of what we usebitsandbytesfor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good but that needs to be seperate (and tested!), I dont have a AMD gpu ;).