Fix the odd off-center rotation issue in Danmakufu #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As well as remove an unusual bias variable that seemingly did nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Danmakufu uses Direct3D 9, it uses texels instead of pixels in it's coordinate system. MKM tried to fix this by applying a 0.5 offset to the vertexes of graphics but this actually causes the graphics to be off-center. This pull-request changes it so the offsets are applied to the actual positions of the graphics and not the vertexes.
This may not be the best way of going about fixing it but I do hope at the very least some insight can be derived from the comparisons in this pull.