Skip to content

Commit

Permalink
fix: fixed a type for AsyncComponentFactory component
Browse files Browse the repository at this point in the history
  • Loading branch information
NataliaTepluhina committed Jul 14, 2019
1 parent a99c667 commit f75a39d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion types/options.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export type AsyncComponentPromise<Data=DefaultData<never>, Methods=DefaultMethod
) => Promise<Component | EsModuleComponent> | void;

export type AsyncComponentFactory<Data=DefaultData<never>, Methods=DefaultMethods<never>, Computed=DefaultComputed, Props=DefaultProps> = () => {

This comment has been minimized.

Copy link
@pikax

pikax Jul 22, 2019

Data, Methods, Computed and Props are not used, wouldn't be better removed them?

component: AsyncComponentPromise<Data, Methods, Computed, Props>;
component: Promise<Component | EsModuleComponent>;
loading?: Component | EsModuleComponent;
error?: Component | EsModuleComponent;
delay?: number;
Expand Down

0 comments on commit f75a39d

Please sign in to comment.