Set a keepalive_connections_max_age to expire excessively long running connections.#695
Open
jtmkrueger wants to merge 1 commit intomainfrom
Open
Set a keepalive_connections_max_age to expire excessively long running connections.#695jtmkrueger wants to merge 1 commit intomainfrom
jtmkrueger wants to merge 1 commit intomainfrom
Conversation
jtmkrueger
commented
Feb 6, 2026
| end | ||
|
|
||
| def test_max_connection_age_closes_connections | ||
| envoy_upstream_keepalive_connections_max_age = 5 |
Collaborator
Author
There was a problem hiding this comment.
Set this super short in the test so it doesn't clog up CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves 18F/api.data.gov#686
The actual change here is pretty minimal, but I put in a test to document what's going on. By setting
keepalive_connections_max_agewe just close connections after they've been hanging around for the time limit. I went with 30 minutes but that's an easy change if you're thinking it needs to be longer or shorter.