SAM 2102 PV Sizing macro annual values issue #2103
Merged
+273
−1,002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Report average annual totals for clipping and power limiting losses -- note that SAM shows year 1 values, so macro results will differ from SAM results. * Add graph showing annual inverter power limiting losses -- this is useful to show how losses decrease over time due to array DC degradation. * Delete image files after displaying macro results window. * Prompt for a folder for save to HTML option and save image files to same folder as HTML file to avoid files being saved in SAM application folder. * Fix some minor HTML syntax issues. Note that `cwd()` function from macro returns SAM application folder instead of folder containing .sam file. Fixes #2102
Remove from PVWatts Wind Battery Hybrid folder -- macro requires Detailed PV model.
cpaulgilman
changed the title
Collaborator
|
@cpaulgilman are you sure this was based off of patch? This looks like it came from develop: 
|
mjprilliman
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixes issues with PV system sizing macro:
Fixes #2102
Corresponding branches and PRs:
None
Unit Test Impact:
None
Checklist