Address menu and page selection #2099#2100
Merged
Conversation
Fix check on opening CSV file.
…_page` from macro. But `SwitchToPage` should not need to be called here.
cpaulgilman
approved these changes
Aug 14, 2025
Collaborator
cpaulgilman
left a comment
cpaulgilman
left a comment
There was a problem hiding this comment.
Navigation menu / input page sync looks good. Thanks for the quick fix!
I removed the test macro.
Should these api_autogen files be part of this PR? 3578a20
Collaborator
Author
Collaborator
I think the best practice is to add them in the PR that makes the changes, but I haven't thought of a good way to make that universal. In a case like this where they're coming from an unrelated PR I'm inclined to merge them in rather than re-working the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test with steps on #2099 and per Word document for creating new case and running macros.
Note that "show page test" macro is still included. Please delete before merging.
GitHubIssuesSAM_2099.zip