Skip to content

Make ExternalInterface:FunctionalMockupUnitExport:To:Schedule/Actuator Initial Value field optional #10943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Myoldmopar merged 8 commits into from
Apr 9, 2025
Merged

Make ExternalInterface:FunctionalMockupUnitExport:To:Schedule/Actuator Initial Value field optional #10943

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
24e8b6a
Un-require FMU:To:Actuator initial value
mjwitte Feb 17, 2025
2af6587
Un-require FMU:To:Actuator initial value
mjwitte Feb 17, 2025
752e3ac
Controller:MechanicalVentilation fatal error with zero zones
mjwitte Feb 17, 2025
2bd493a
Merge remote-tracking branch 'remotes/origin/develop' into miscCleanu…
mjwitte Feb 25, 2025
1da0183
SpaceHVAC memo updates
mjwitte Mar 3, 2025
d791c77
Revert "Controller:MechanicalVentilation fatal error with zero zones"
mjwitte Mar 10, 2025
69e06b4
Merge remote-tracking branch 'remotes/origin/develop' into miscCleanu…
mjwitte Mar 10, 2025
d5d55c0
Merge remote-tracking branch 'remotes/origin/develop' into miscCleanu…
mjwitte Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions idd/Energy+.idd.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50621,7 +50621,7 @@ SpaceHVAC:EquipmentConnections,
\memo Specifies the HVAC equipment connections for a space. Node names are specified for the
\memo space air node, air inlet nodes, air exhaust nodes, and the air return node.
\memo If any space in a zone has a SpaceHVAC:EquipmentConnections object, then all spaces in the zone must have one.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Sizing"is Yes.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Simulation" is Yes.
Copy link
Member

@Myoldmopar Myoldmopar Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fine fix

\min-fields 4
A1 , \field Space Name
\required-field
Expand Down Expand Up @@ -50654,13 +50654,13 @@ SpaceHVAC:ZoneEquipmentSplitter,
\memo Distributes the output from a piece of zone equipment to one or more Spaces in the Zone.
\memo If any equipment in a zone has a SpaceHVAC:ZoneEquipmentSplitter, then all equipment in the zone must have one.
\memo except Fan:ZoneExhaust. All spaces in the zone must also have a SpaceHVAC:EquipmentConnections object.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Sizing" = Yes.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Simulation" is Yes.
\min-fields 10
A1, \field Name
\required-field
\reference SpaceSplitterNames
A2, \field Zone Name
\note Must be a controlled zone which has a ZoneHVAC:EquipmentConfiguration object.
\note Must be a controlled zone which has a ZoneHVAC:EquipmentConnections object.
Copy link
Member

@Myoldmopar Myoldmopar Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good.

\required-field
\type object-list
\object-list ZoneNames
Expand Down Expand Up @@ -50778,13 +50778,13 @@ SpaceHVAC:ZoneEquipmentMixer,
\extensible:3
\memo Mixes the airflow from one or more Spaces into a piece of zone equipment.
\memo All spaces in the zone must also have a SpaceHVAC:EquipmentConnections object.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Sizing" = Yes.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Simulation" is Yes.
\min-fields 7
A1, \field Name
\required-field
\reference SpaceMixerNames
A2, \field Zone Name
\note Must be a controlled zone which has a ZoneHVAC:EquipmentConfiguration object.
\note Must be a controlled zone which has a ZoneHVAC:EquipmentConnections object.
\required-field
\type object-list
\object-list ZoneNames
Expand Down Expand Up @@ -50849,13 +50849,13 @@ SpaceHVAC:ZoneReturnMixer,
\extensible:2
\memo Mixes the return airflow from one or more Spaces into a zone return node.
\memo All spaces in the zone must also have a SpaceHVAC:EquipmentConnections object.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Sizing" = Yes.
\memo Used only when ZoneAirHeatBalanceAlgorithm "Do Space Heat Balance for Simulation" is Yes.
\min-fields 5
A1, \field Name
\required-field
\reference SpaceMixerNames
A2, \field Zone Name
\note Must be a controlled zone which has a ZoneHVAC:EquipmentConfiguration object.
\note Must be a controlled zone which has a ZoneHVAC:EquipmentConnections object.
\required-field
\type object-list
\object-list ZoneNames
Expand Down Expand Up @@ -85417,8 +85417,7 @@ ExternalInterface:FunctionalMockupUnitExport:To:Schedule,
\retaincase
N1 ; \field Initial Value
\type real
\required-field
\note Used during the first call of EnergyPlus.
\note Used during EnergyPlus sizing and warm-up.
Copy link
Contributor

@jmarrec jmarrec Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumErrorFlag is set. But that's not used later to throw.

Is allowing a blank really intended though, given the warning?

https://github.com/NREL/EnergyPlus/blob/0befe779fe9721745ba31a65f877cc05905ac6b3/src/EnergyPlus/ScheduleManager.cc#L2047-L2053

Copy link
Contributor Author

@mjwitte mjwitte Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarrec I wasn't set up to test this, so it was tested by two others. This warning should go, but I wonder if line 2053 should be inside this if.

Copy link
Contributor Author

@mjwitte mjwitte Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, looking further at this code, it appears that this is creating a new schedule, so it would need a value to initialize it.


ExternalInterface:FunctionalMockupUnitExport:To:Actuator,
\memo Hardware portion of EMS used to set up actuators in the model
Expand All @@ -85444,8 +85443,8 @@ ExternalInterface:FunctionalMockupUnitExport:To:Actuator,
\retaincase
N1 ; \field Initial Value
\type real
\required-field
\note Used during the first call of EnergyPlus.
\note Used during EnergyPlus sizing and warm-up.
\note If no value is specified, then the actuated component will only be updated after sizing and warm-up.
Copy link
Member

@Myoldmopar Myoldmopar Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.


ExternalInterface:FunctionalMockupUnitExport:To:Variable,
\memo Declares Erl variable as having global scope
Expand All @@ -85463,7 +85462,7 @@ ExternalInterface:FunctionalMockupUnitExport:To:Variable,
N1 ; \field Initial Value
\type real
\required-field
\note Used during the first call of EnergyPlus.
\note Used during EnergyPlus sizing and warm-up.
Copy link
Member

@Myoldmopar Myoldmopar Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


\group User Defined HVAC and Plant Component Models

Expand Down